k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(tours): a checklist cut short past its cap, and a decision save failing part way stores nothing

Browse Source
This commit is contained in:
Maurice
2026-10-17 00:31:29 +00:00
parent 7fffd4300f
commit 14b917ee97
1 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/nest/tours.paddle-check.test.ts
+40
View File
@@ -26,6 +26,7 @@ import { resetTestDb } from '../../helpers/test-db';
import { createTestModule, type TestModule } from '../../helpers/test-module';
import { MikroORM } from '@mikro-orm/core';
import {
PADDLE_CHECK_MAX_ENTRIES,
tourDetailResponseSchema,
tourListItemSchema,
type ObstacleDecision,
@@ -296,6 +297,21 @@ describe('TourPaddleCheckService: the checklist and the bench', () => {
expect(read).not.toHaveProperty('obstacle_check');
expect(read.tour).not.toHaveProperty('paddle_check');
});
it('TPC-010: an area holding more obstacles than a checklist carries reads as cut short', async () => {
const { trip, paddle } = await fixture();
await region();
await insertRows(
orm(),
PaddleFeatures,
Array.from({ length: PADDLE_CHECK_MAX_ENTRIES + 1 }, (_, i) =>
weir(`node/${i + 1}`, 49.2, 12.0001 + i * 0.00003),
),
);
const read = await detail(trip.id, paddle.id);
expect(read.tour.paddle_check).toMatchObject({ data: 'limited', entries: PADDLE_CHECK_MAX_ENTRIES });
expect(read.obstacle_check?.entries).toHaveLength(PADDLE_CHECK_MAX_ENTRIES);
});
});
describe('TourObstacleReviewsService.save', () => {
@@ -473,6 +489,30 @@ describe('TourObstacleReviewsService.save', () => {
expect(await findRows(orm(), TourObstacleReviews, { place: lineless.id })).toEqual([]);
});
it('TOR-012: a save failing part way stores none of its changes', async () => {
const { user, trip, paddle, entry } = await decidedFixture();
await insertRows(orm(), PaddleFeatures, [weir('node/2', 49.2, 12.008)]);
const read = await detail(trip.id, paddle.id);
const second = read.obstacle_check?.entries.find((candidate) => candidate.key === 'node/2');
if (!second) throw new Error('no second entry');
await reviews.save(String(trip.id), String(paddle.id), { ops: [decide(second, 'pass')] }, user.id);
const repo = orm().em.getRepository(TourObstacleReviews) as unknown as { deleteKeys: () => Promise<number> };
vi.spyOn(repo, 'deleteKeys').mockRejectedValueOnce(new Error('disk full'));
await expect(
reviews.save(
String(trip.id),
String(paddle.id),
{
ops: [decide(entry, 'portage'), { key: 'node/2', op: 'clear', decision: null, note: null, basis: null }],
},
user.id,
),
).rejects.toThrow();
expect(await stored(paddle.id)).toBeNull();
expect(await findRows(orm(), TourObstacleReviews, { place: paddle.id })).toHaveLength(1);
});
it('TOR-011: a copied tour keeps its decisions, bound to what they were decided on', async () => {
const { user, trip, paddle, entry } = await decidedFixture();
await reviews.save(String(trip.id), String(paddle.id), { ops: [decide(entry, 'pass')] }, user.id);