From 125436fa87b54bbbc875c654cf8bddeda46fac3c Mon Sep 17 00:00:00 2001 From: Maurice Date: Thu, 16 Apr 2026 00:12:06 +0200 Subject: [PATCH] fix: correct test matchers for list import and reservations - PlacesSidebar: match "List Import" (actual i18n value) not "Import List" - ReservationsPanel: use unique titles to avoid matching filter buttons --- client/src/components/Planner/PlacesSidebar.test.tsx | 8 ++++---- client/src/components/Planner/ReservationsPanel.test.tsx | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/client/src/components/Planner/PlacesSidebar.test.tsx b/client/src/components/Planner/PlacesSidebar.test.tsx index c72d63f4..7d7221da 100644 --- a/client/src/components/Planner/PlacesSidebar.test.tsx +++ b/client/src/components/Planner/PlacesSidebar.test.tsx @@ -473,14 +473,14 @@ describe('Google Maps list import', () => { it('FE-PLANNER-SIDEBAR-040: "Google List" button opens the URL dialog', async () => { const user = userEvent.setup(); render(); - await user.click(screen.getByText(/Import List/i)); + await user.click(screen.getByText(/List Import/i)); expect(await screen.findByPlaceholderText(/maps\.app\.goo\.gl/i)).toBeInTheDocument(); }); it('FE-PLANNER-SIDEBAR-041: import button disabled when URL input is empty', async () => { const user = userEvent.setup(); render(); - await user.click(screen.getByText(/Import List/i)); + await user.click(screen.getByText(/List Import/i)); await screen.findByPlaceholderText(/maps\.app\.goo\.gl/i); const importBtn = screen.getByRole('button', { name: /^Import$/i }); expect(importBtn).toBeDisabled(); @@ -498,7 +498,7 @@ describe('Google Maps list import', () => { (window as any).__addToast = addToast; const user = userEvent.setup(); render(); - await user.click(screen.getByText(/Import List/i)); + await user.click(screen.getByText(/List Import/i)); const urlInput = await screen.findByPlaceholderText(/maps\.app\.goo\.gl/i); await user.type(urlInput, 'https://maps.app.goo.gl/abc123'); await user.click(screen.getByRole('button', { name: /^Import$/i })); @@ -527,7 +527,7 @@ describe('Google Maps list import', () => { (window as any).__addToast = addToast; const user = userEvent.setup(); render(); - await user.click(screen.getByText(/Import List/i)); + await user.click(screen.getByText(/List Import/i)); const urlInput = await screen.findByPlaceholderText(/maps\.app\.goo\.gl/i); await user.type(urlInput, 'https://maps.app.goo.gl/xyz{Enter}'); await waitFor(() => { diff --git a/client/src/components/Planner/ReservationsPanel.test.tsx b/client/src/components/Planner/ReservationsPanel.test.tsx index f461251e..2dcd9c86 100644 --- a/client/src/components/Planner/ReservationsPanel.test.tsx +++ b/client/src/components/Planner/ReservationsPanel.test.tsx @@ -92,11 +92,11 @@ describe('ReservationsPanel', () => { }); it('FE-COMP-RES-010: shows reservations title and cards', () => { - const r1 = buildReservation({ title: 'Flight', type: 'flight', status: 'confirmed' }); - const r2 = buildReservation({ title: 'Hotel', type: 'hotel', status: 'pending' }); + const r1 = buildReservation({ title: 'My Flight Booking', type: 'flight', status: 'confirmed' }); + const r2 = buildReservation({ title: 'Grand Hotel', type: 'hotel', status: 'pending' }); render(); - expect(screen.getByText('Flight')).toBeInTheDocument(); - expect(screen.getByText('Hotel')).toBeInTheDocument(); + expect(screen.getByText('My Flight Booking')).toBeInTheDocument(); + expect(screen.getByText('Grand Hotel')).toBeInTheDocument(); }); it('FE-COMP-RES-011: hotel reservation renders', () => {