From 0f63ced4a94dac6a304ca0e2667150065a63f2cd Mon Sep 17 00:00:00 2001 From: jubnl Date: Tue, 28 Apr 2026 13:36:29 +0200 Subject: [PATCH] fix: non-transport reservations no longer appear as transports in day planner (issue #914) getTransportForDay now uses TRANSPORT_TYPES allowlist instead of only excluding hotels, and the click handler dispatches to onEditReservation for non-transport types instead of always opening TransportModal, preventing silent type coercion to 'flight'. --- client/src/components/Planner/DayPlanSidebar.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/client/src/components/Planner/DayPlanSidebar.tsx b/client/src/components/Planner/DayPlanSidebar.tsx index 7c44f091..967cbfcc 100644 --- a/client/src/components/Planner/DayPlanSidebar.tsx +++ b/client/src/components/Planner/DayPlanSidebar.tsx @@ -398,7 +398,7 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar({ const getTransportForDay = (dayId: number) => { const dayAssignmentIds = (assignments[String(dayId)] || []).map(a => a.id) return reservations.filter(r => { - if (r.type === 'hotel') return false + if (!TRANSPORT_TYPES.has(r.type)) return false if (r.assignment_id && dayAssignmentIds.includes(r.assignment_id)) return false const startDayId = r.day_id @@ -1726,7 +1726,11 @@ const DayPlanSidebar = React.memo(function DayPlanSidebar({ return (
canEditDays && onEditTransport?.(res)} + onClick={() => { + if (!canEditDays) return + if (TRANSPORT_TYPES.has(res.type)) onEditTransport?.(res) + else onEditReservation?.(res) + }} onDragOver={e => { e.preventDefault(); e.stopPropagation() const rect = e.currentTarget.getBoundingClientRect()