k1nq/TREK
1
0
Fork 0
mirror of https://github.com/mauriceboe/TREK.git synced 2026-10-18 21:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(vacay): stop swallowing a failed delete as a holiday API error

Browse Source 
One try around the holiday fetch and the deletes that follow it caught
both, so a database error while removing vacation days that fall on a
public holiday was logged as nothing and left the days standing. Only
the fetch is tolerated now. Also drops two files long gone from the
Sonar coverage exclusions.
This commit is contained in:
Maurice
2026-10-07 16:59:52 +02:00
parent 48f9e7d132
commit 094a46a3cf
3 changed files with 44 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/tests/unit/nest/vacay.service.test.ts
+15
View File
@@ -1472,6 +1472,21 @@ describe('applyHolidayCalendars', () => {
.all(plan.id, holidayDate);
expect(remaining).toHaveLength(0);
});
it('VACAY-SVC-047b: a holiday API that does not answer is skipped, a failing delete is not', async () => {
const { plan } = await setupUserWithPlan();
testDb.prepare('UPDATE vacay_plans SET holidays_enabled = 1 WHERE id = ?').run(plan.id);
await svc.addHolidayCalendar(plan.id, 'FR', null, undefined, 0, undefined);
vi.stubGlobal('fetch', vi.fn().mockRejectedValue(new TypeError('fetch failed')));
await expect(svc.applyHolidayCalendars(plan.id)).resolves.toBeUndefined();
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({ ok: true, json: async () => [{ date: '2031-07-14', global: true }] }));
const entries = (svc as unknown as { entries: { deleteForPlanAndDate: () => Promise<void> } }).entries;
const del = vi.spyOn(entries, 'deleteForPlanAndDate').mockRejectedValueOnce(new Error('database is locked'));
await expect(svc.applyHolidayCalendars(plan.id)).rejects.toThrow('database is locked');
del.mockRestore();
});
});
// ── Read-only calendar shares (#444/#667) ─────────────────────────────────────