From 030918cfa919c5994eb9d40c8516e86676aa26db Mon Sep 17 00:00:00 2001 From: Maurice Date: Sat, 31 Oct 2026 12:09:32 +0100 Subject: [PATCH] ci(release): check the dialect with node's types TypeScript 6 includes no @types unless a file imports from them, and the issued dialect imports nothing from node. Type-checked on its own it did not know Buffer, so the 5.1.0 release threw away a valid dialect as one that does not type-check. The check config names node now. --- .github/workflows/registration-dialect.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/registration-dialect.yml b/.github/workflows/registration-dialect.yml index 0b9f91f94..40d657619 100644 --- a/.github/workflows/registration-dialect.yml +++ b/.github/workflows/registration-dialect.yml @@ -120,7 +120,9 @@ jobs: run: | set -uo pipefail cp "$FILE" src/nest/service-identity/registration-dialect.ts - printf '%s\n' '{"extends": "./tsconfig.strict.json", "include": [],' \ + # TypeScript 6 includes no @types by default and the dialect imports nothing + # from node, so checked on its own it would not know Buffer: name node here. + printf '%s\n' '{"extends": "./tsconfig.strict.json", "compilerOptions": {"types": ["node"]}, "include": [],' \ '"files": ["src/nest/service-identity/registration-dialect.ts"]}' > tsconfig.dialect-check.json if ! npx tsc -p tsconfig.dialect-check.json --noEmit --pretty false; then echo "::warning::The issuer's registration dialect for $VERSION does not type-check under the strict config."